This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix relro strip test for MIPS


On Wed, Oct 10, 2007 at 11:11:18AM -0700, H.J. Lu wrote:
> On Thu, Sep 27, 2007 at 01:54:44PM +0930, Alan Modra wrote:
> > On Sat, Sep 22, 2007 at 02:17:08PM -0700, H.J. Lu wrote:
> > > We can call assign_file_positions_for_load_sections to get the
> > > load section layout and find out if the PT_GNU_RELRO segment will
> > > be empty or not.
> > 
> > I haven't been following this thread closely, but I really don't like
> > calling assign_file_positions_for_load_sections early like this.
> > Can't you determine whether a PT_GNU_RELRO program header will be
> > needed just by looking at the PT_LOAD sections in
> > _bfd_elf_map_sections_to_segments?
> > 
> 
> This patch
> 
> http://sourceware.org/ml/binutils/2007-09/msg00324.html
> 
> doesn't call assign_file_positions_for_load_sections.

This patch is OK.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]