This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Fix relro strip test for MIPS
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl at lucon dot org>
- Cc: binutils at sourceware dot org
- Date: Thu, 11 Oct 2007 09:35:31 +0930
- Subject: Re: PATCH: Fix relro strip test for MIPS
- References: <20070919175201.GA4082@caradoc.them.org> <20070919181413.GA12519@lucon.org> <20070920063212.GB29574@bubble.grove.modra.org> <20070920175725.GA19023@lucon.org> <20070920180751.GA9886@caradoc.them.org> <20070920185820.GA19623@lucon.org> <20070921165900.GA19837@lucon.org> <20070922211708.GA30459@lucon.org> <20070927042444.GB21314@bubble.grove.modra.org> <20071010181118.GA12326@lucon.org>
On Wed, Oct 10, 2007 at 11:11:18AM -0700, H.J. Lu wrote:
> On Thu, Sep 27, 2007 at 01:54:44PM +0930, Alan Modra wrote:
> > On Sat, Sep 22, 2007 at 02:17:08PM -0700, H.J. Lu wrote:
> > > We can call assign_file_positions_for_load_sections to get the
> > > load section layout and find out if the PT_GNU_RELRO segment will
> > > be empty or not.
> >
> > I haven't been following this thread closely, but I really don't like
> > calling assign_file_positions_for_load_sections early like this.
> > Can't you determine whether a PT_GNU_RELRO program header will be
> > needed just by looking at the PT_LOAD sections in
> > _bfd_elf_map_sections_to_segments?
> >
>
> This patch
>
> http://sourceware.org/ml/binutils/2007-09/msg00324.html
>
> doesn't call assign_file_positions_for_load_sections.
This patch is OK.
--
Alan Modra
Australia Development Lab, IBM