This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tue, Oct 16, 2007 at 10:02:17AM +0930, Alan Modra wrote:On Mon, Oct 15, 2007 at 03:42:37PM -0700, Bob Wilson wrote:- if (kept != NULL && sec->size != kept->size)
+ /* The kept section may have been relaxed; compare its original size. */
+ if (kept != NULL
+ && (elf_section_data (sec)->this_hdr.sh_size
+ != elf_section_data (kept)->this_hdr.sh_size))
What if "sec" is non-ELF? (I'm not dead certain this can happen, but I think it can..)
I think you should probably use
if (kept != NULL && ((sec->rawsize != 0 ? sec->rawsize : sec->size) == (kept->rawsize != 0 ? kept->rawsize : kept->size)))
OK with that change.
Thanks, Bob
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |