This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to detect invalid mergeable string sections


On Tue, Oct 30, 2007 at 04:10:18PM +0000, Joseph S. Myers wrote:
> +	      if (sec_end && s >= sec_end)
> +		{
> +		  (*_bfd_error_handler)
> +		    (_("unterminated string in section marked for merging"));
> +		  return NULL;
> +		}

It would be nice if this error specified the section.  I think you can
do that by simply returning NULL here and calling _bfd_error_handler
at error_return in record_section after testing for bfd_get_error
returning anything but bfd_error_no_memory.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]