This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
objcopy sets pe_opthdr.Subsystem in _bfd_XXi_swap_aouthdr_out if it is IMAGE_SUBSYSTEM_UNKNOWN. But _bfd_XX_bfd_copy_private_bfd_data_common copies pe_opthdr.Subsystem from input to output so that pe_opthdr.Subsystem is never changed. This patch sets pe_opthdr.Subsystem to IMAGE_SUBSYSTEM_UNKNOWN if output is different from input.
Wouldn't you normally want the default subsystem of the output? Isn't it IMAGE_SUBSYSTEM_EFI_APPLICATION for efi-app-* ? Wouldn't a more general objcopy flag to change the subsystem to the one you want be more useful (like ld's --subsystem) ?
Cheers, Pedro Alves
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |