This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FAIL for your new ld flags test for cris-elf


> Date: Tue, 13 Nov 2007 14:12:12 -0800
> From: "H.J. Lu" <hjl@lucon.org>

> On Tue, Nov 13, 2007 at 11:06:21PM +0100, Hans-Peter Nilsson wrote:
> > For your new test, I get for cris-elf (from ld.log):
> > 
> > regexp_diff match failure
> > regexp "^  LOAD +0x[0-9a-f]+ 0x0*0 0x0*0 0x0*0161 0x0*0161 RWE 0x[0-9a-f]+$"
> > line   "  LOAD           0x002000 0x00000000 0x00000000 0x00164 0x00164 RWE 0x2000"
> > FAIL: --set-section-flags test 1 (sections)
> > 
> > Would you prefer to change the regexp match (twice above) to
> > 0x0*016[1-8] or to add "#notarget: cris-*-*"?  I can't see where
> > .text automatically is promised exactly 4-byte alignment, so I
> > lean towards the former.
> 
> Either way is fine with me.

I thought you were on the hook to fix this, but I see my reply
could seem like I was about to fix it.  Committed, then.

ld/testsuite:
	* ld-elf/flags1.d: Generalize regexp for section size.

Index: ld-elf/flags1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/flags1.d,v
retrieving revision 1.1
diff -u -p -r1.1 flags1.d
--- ld-elf/flags1.d	13 Nov 2007 13:20:02 -0000	1.1
+++ ld-elf/flags1.d	14 Nov 2007 09:59:58 -0000
@@ -6,7 +6,7 @@
 #...
 Program Headers:
   Type.*
-  LOAD +0x[0-9a-f]+ 0x0*0 0x0*0 0x0*0161 0x0*0161 RWE 0x[0-9a-f]+
+  LOAD +0x[0-9a-f]+ 0x0*0 0x0*0 0x0*016[1-8] 0x0*016[1-8] RWE 0x[0-9a-f]+
 
 #...
   Segment Sections...

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]