This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[Xtensa] fix testsuite failures
- From: Bob Wilson <bwilson at tensilica dot com>
- To: binutils at sources dot redhat dot com
- Date: Mon, 04 Feb 2008 15:41:02 -0800
- Subject: [Xtensa] fix testsuite failures
I've most often been running the binutils testsuites with an xtensa-elf target,
often without a cross-compiler on my path. Today I tried with an
xtensa-linux-uclibc target where the compiler was also available, and it exposed
a few problems. I've committed this patch to fix them.
2008-02-04 Bob Wilson <bob.wilson@acm.org>
binutils/testsuite/
* binutils-all/objdump.exp (cpus_expected): Add xtensa.
ld/testsuite/
* ld-undefined/undefined.exp: XFAIL for xtensa*-*-linux*.
Index: binutils/testsuite/binutils-all/objdump.exp
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/objdump.exp,v
retrieving revision 1.21
diff -u -r1.21 objdump.exp
--- binutils/testsuite/binutils-all/objdump.exp 5 Jul 2007 16:54:45 -0000 1.21
+++ binutils/testsuite/binutils-all/objdump.exp 4 Feb 2008 23:29:36 -0000
@@ -42,7 +42,7 @@
lappend cpus_expected mips mn10200 mn10300 msp ns32k pj powerpc pyramid
lappend cpus_expected romp rs6000 s390 sh sparc
lappend cpus_expected tahoe tic54x tic80 tms320c30 tms320c4x tms320c54x v850
-lappend cpus_expected vax we32k x86-64 xscale z8k z8001 z8002
+lappend cpus_expected vax we32k x86-64 xscale xtensa z8k z8001 z8002
# Make sure the target CPU shows up in the list.
lappend cpus_expected ${target_cpu}
Index: ld/testsuite/ld-undefined/undefined.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-undefined/undefined.exp,v
retrieving revision 1.28
diff -u -r1.28 undefined.exp
--- ld/testsuite/ld-undefined/undefined.exp 28 Aug 2007 13:21:58 -0000 1.28
+++ ld/testsuite/ld-undefined/undefined.exp 4 Feb 2008 23:29:36 -0000
@@ -71,6 +71,12 @@
#setup_xfail "arm*-*-pe*"
#setup_xfail "thumb*-*-pe*"
+# For Xtensa on GNU Linux systems (or any other system where PIC code is
+# always used), the address of the undefined function is in a literal pool
+# outside the function, so that both the "undefined function" and "undefined
+# line" tests fail.
+setup_xfail xtensa*-*-linux*
+
set mf "tmpdir/undefined.o* In function `function':"
checkund $mf $testfn
@@ -132,4 +138,7 @@
# doesn't need a literal pool entry.
setup_xfail s390-*-*
+# See comments above for Xtensa.
+setup_xfail xtensa*-*-linux*
+
checkund $ml $testline