Re: [PATCH] enhance register parsing in .cfi_* handling

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Feb 11, 2008 at 03:32:08PM +0000, Jan Beulich wrote:
> >>> "H.J. Lu" <hjl.tools@gmail.com> 11.02.08 16:11 >>>
> >On Mon, Feb 11, 2008 at 10:51:34AM +0000, Jan Beulich wrote:
> >> +rax, Reg64|BaseIndex|Acc|Qword, 0, 0, , 0
> >
> >Can you use
> >
> >rax, Reg64|BaseIndex|Acc|Qword, 0, 0, -1, 0
> >
> >and remove special handling of "" in i386-gen.c?
> 
> I'd rather not, as this way it's much simple to change the 'invalid'
> indicator if need be. Also, the special case handling isn't only about

Different fields may have different 'invalid' indicators. I prefer we
define them in i386-reg.tbl directly.

> blank fields, but also about missing trailing ones - if you want that
> removed, too, it'd mean adding much more useless stuff to registers
> not validly subject of .cfi_* directives.

I would pefer to add those 'invalid' indicators to registers which
aren't used in .cfi_* directives. It will make i386-reg.tbl easier
to understand/compare.

Thanks.

H.J.