This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Fix installed dlltool testing
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: binutils at sourceware dot org
- Date: Mon, 25 Feb 2008 22:16:47 +0000 (UTC)
- Subject: Fix installed dlltool testing
This patch fixes testing dlltool in installed toolchain testing (runtest
--tool binutils, having created an appropriate site.exp). The code
looking for gas in the build tree fails in that case, so options expecting
such a copy of gas should not be passed to dlltool.
This changes
FAIL: dlltool -p (execution)
into
PASS: dlltool -p (execution)
PASS: dlltool -p (symbol names)
PASS: dlltool -p (import name)
testing a cross from i686-pc-linux-gnu to i686-mingw32 with installed
testing, and the tests also pass in build-tree testing. OK to commit?
2008-02-25 Joseph Myers <joseph@codesourcery.com>
* config/default.exp (gcc_gas_flag, dlltool_gas_flag): Define to
empty for testing an installed toolchain.
Index: config/default.exp
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/config/default.exp,v
retrieving revision 1.12
diff -u -r1.12 default.exp
--- config/default.exp 5 Jul 2007 16:54:45 -0000 1.12
+++ config/default.exp 25 Feb 2008 22:12:27 -0000
@@ -94,8 +94,14 @@
} else {
link_or_copy ld/ld-new ld[exe_ext]
}
-set gcc_gas_flag "-B[pwd]/tmpdir/gas/"
-set dlltool_gas_flag "-S [pwd]/tmpdir/gas/as[exe_ext]"
+if {[file isfile tmpdir/gas/as[exe_ext]]} then {
+ set gcc_gas_flag "-B[pwd]/tmpdir/gas/"
+ set dlltool_gas_flag "-S [pwd]/tmpdir/gas/as[exe_ext]"
+} else {
+ # Testing an installed toolchain.
+ set gcc_gas_flag ""
+ set dlltool_gas_flag ""
+}
#
# binutils_run
--
Joseph S. Myers
joseph@codesourcery.com