This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Fwd: [gas patch] hppa: remove the no longer used is_same_frag()
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Binutils <binutils at sourceware dot org>
- Cc: "Adrian Bunk" <adrian dot bunk at movial dot fi>
- Date: Sun, 16 Mar 2008 15:23:11 -0700
- Subject: Fwd: [gas patch] hppa: remove the no longer used is_same_frag()
- References: <20080316204635.GF4902@cs181133002.pp.htv.fi>
Hi,
I am forwarding this to <binutils@sourceware.org>.
H.J.
---------- Forwarded message ----------
From: Adrian Bunk <adrian.bunk@movial.fi>
Date: Sun, Mar 16, 2008 at 1:46 PM
Subject: [gas patch] hppa: remove the no longer used is_same_frag()
To: hjl.tools@gmail.com
The only remaining user of is_same_frag() was the function recursively
calling itself.
Different from earlier gcc versions, gcc 4.3 detects and warns about
this fact, which leads due to -Werror to the following build error:
<-- snip -->
...
gcc -DHAVE_CONFIG_H -I. -I/TMP/binutils-2.18.50.0.5/gas -I. -I.
-I/TMP/binutils-2.18.50.0.5/gas -I../bfd
-I/TMP/binutils-2.18.50.0.5/gas/config
-I/TMP/binutils-2.18.50.0.5/gas/../include
-I/TMP/binutils-2.18.50.0.5/gas/..
-I/TMP/binutils-2.18.50.0.5/gas/../bfd
-DLOCALEDIR="\"/usr/local/DIR/binutils-hppa-2.18.50.0.5/share/locale\""
-W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror -O2
-march=k8 -c /TMP/binutils-2.18.50.0.5/gas/config/tc-hppa.c
cc1: warnings being treated as errors
/TMP/binutils-2.18.50.0.5/gas/config/tc-hppa.c:5905: error:
'is_same_frag' defined but not used
make[4]: *** [tc-hppa.o] Error 1
<-- snip -->
Also reported in the binutils Bugzilla as #5946.
--- gas/config/tc-hppa.c.old 2008-03-16 21:55:08.000000000 +0200
+++ gas/config/tc-hppa.c 2008-03-16 21:55:24.000000000 +0200
@@ -5898,24 +5898,6 @@
demand_empty_rest_of_line ();
}
-/* Return TRUE if FRAG1 and FRAG2 are the same. */
-
-static bfd_boolean
-is_same_frag (fragS *frag1, fragS *frag2)
-{
-
- if (frag1 == NULL)
- return FALSE;
- else if (frag2 == NULL)
- return FALSE;
- else if (frag1 == frag2)
- return TRUE;
- else if (frag2->fr_type == rs_fill && frag2->fr_fix == 0)
- return (is_same_frag (frag1, frag2->fr_next));
- else
- return FALSE;
-}
-
#ifdef OBJ_ELF
/* Build an entry in the UNWIND subspace from the given function
attributes in CALL_INFO. This is not needed for SOM as using