This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, MIPS]: Add most of the Octeon instructions


Hi Adam,

Ping^2.

include/opcode/

	* mips.h: Document new field descriptors +x, +X, +p, +P, +s, +S.
	Update comment before MIPS16 field descriptors to mention MIPS16.
	(OP_SH_BBITIND, OP_MASK_BBITIND): New bit mask and shift count for
	BBIT.
	(OP_SH_CINSPOS, OP_MASK_CINSPOS, OP_SH_CINSLM1, OP_MASK_CINSLM1):
	New bit masks and shift counts for cins and exts.

gas/

	* config/tc-mips.c (validate_mips_insn): Handle field descriptors
	+x, +X, +p, +P, +s, +S.
	(mips_ip): Likewise.

opcodes/

	* mips-dis.c (print_insn_args): Handle field descriptors +x, +p,
	+s, +S.
	* mips-opc.c (mips_builtin_opcodes): Add Octeon instructions
	baddu, bbit*, cins*, dmul, pop, dpop, exts*, mtm*, mtp*, syncs,
	syncw, syncws, vm3mulu, vm0 and vmulu.

gas/testsuite/

	* gas/mips/octeon.s, gas/mips/octeon.d: Add tests for baddu,
	bbit*, cins*, dmul, pop, dpop, exts*, mtm*, mtp*, syncs, syncw,
	syncws, vm3mulu, vm0 and vmulu.
	* gas/mips/octeon-ill.s, gas/mips/octeon-ill.s: New test.
	* gas/mips/mips.exp: Run it.  Run octeon test with
	run_dump_test_arches.

Approved and applied.


Sorry for the long delay in reviewing this patch. I was hoping that a MIPS maintainer might take a look at it ... :-)

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]