This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING : [PATCH] Add support for Xilinx FP/APU to PowerPC


Please approve & check in.

Michael Eager wrote:
Alan Modra wrote:
On Fri, May 23, 2008 at 01:51:43PM -0700, Michael Eager wrote:
Could someone please check this in?

No, it has some errors I think. I glanced at it a month ago, saw one error and put it aside for a proper review, then forgot about it. Sorry for the delay.

+/* Opcode is supported by PowerPC 405 processor.  */
+#define PPC_OPCODE_405         0x10000000

Reuse PPC_OPCODE_PPCPS??

Oops. :-)



{"nmaclhwso.", XO (4, 494,1,1),XO_MASK, PPC405|PPC440, {RT, RA, RB}},
+
+{"get", APU(4,536), APU_RA_MASK, PPC405 | PPC32, { RT, FSL } },

This isn't the right place to insert these new opcodes. I'm trying to keep the table more or less sorted, so that you can more easily see when cpu variants use the same opcode for different instructions. So "get" ought to go after "evnot", "cget" after "evcmpeq" and so on.

I revised the patch and changed the APU macro so that rc is factored out, like the A() macro. This makes it easier to put the opcodes in order. I did notice that there was a re-use of an opcode in one of the added instructions. I removed this instruction (and the similar ones) and will submit those as a patch when I resolve the conflict.



--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]