This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH COMMITTED: Add depcomp to snapshots and releases


Daniel Jacobowitz <drow@false.org> writes:

> On Thu, Jun 19, 2008 at 12:19:31AM +0200, Andreas Schwab wrote:
>> Ian Lance Taylor <iant@google.com> writes:
>> 
>> > gold uses automake dependency generation, which uses the depcomp
>> > script.  This script is in the CVS repository, but it was not being
>> > put into snapshots or release tarballs.
>> 
>> But depcomp is already in DEVO_SUPPORT.
>
> Ian, I don't suppose this was an old issue you'd been meaning to fix?
>
> I updated the list for GDB mid-May.

Hmmm, I was actually just reacting to a bug report about the binutils
snapshots.  I didn't look into it farther than observing that depcomp
was not in BINUTILS_SUPPORT_DIRS.

Now that I look at this a bit more, I see that the last time we
generated a binutils daily snapshot was May 16.  It fails like this:

ln: `proto-toplev/mkdep': File exists
make[2]: *** [do-proto-toplev] Error 1
make[2]: Leaving directory `/export/u0/sourceware/sourceware/snapshot-tmp/binutils-snapshot/asnap080618.27541/src'
make[1]: *** [taz] Error 2
make[1]: Leaving directory `/export/u0/sourceware/sourceware/snapshot-tmp/binutils-snapshot/asnap080618.27541/src'
make: *** [binutils.tar.bz2] Error 2
make: Leaving directory `/export/u0/sourceware/sourceware/snapshot-tmp/binutils-snapshot/asnap080618.27541/src'

So now it seems that my change was exactly what I should not have
done.  I have now committed this patch.

Thanks for catching this.

Ian


2008-06-18  Ian Lance Taylor  <iant@google.com>

	* src-release (BINUTILS_SUPPORT_DIRS): Remove mkdep and depcomp.


Index: src-release
===================================================================
RCS file: /cvs/src/src/src-release,v
retrieving revision 1.30
diff -u -r1.30 src-release
--- src-release	18 Jun 2008 20:06:36 -0000	1.30
+++ src-release	18 Jun 2008 23:18:32 -0000
@@ -249,7 +249,7 @@
 
 # The FSF "binutils" release includes gprof and ld.
 .PHONY: binutils.tar.bz2
-BINUTILS_SUPPORT_DIRS= bfd gas include libiberty opcodes ld elfcpp gold gprof intl setup.com makefile.vms mkdep cpu depcomp
+BINUTILS_SUPPORT_DIRS= bfd gas include libiberty opcodes ld elfcpp gold gprof intl setup.com makefile.vms cpu
 binutils.tar.bz2: $(DIST_SUPPORT) $(BINUTILS_SUPPORT_DIRS) binutils
 	$(MAKE) -f $(SELF) taz TOOL=binutils \
 		MD5PROG="$(MD5PROG)" \

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]