This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: support compressed sections in addr2line, objdump, readelf
- From: Andreas Schwab <schwab at suse dot de>
- To: csilvers at google dot com (Craig Silverstein)
- Cc: binutils at sourceware dot org
- Date: Thu, 10 Jul 2008 18:24:25 +0200
- Subject: Re: PATCH: support compressed sections in addr2line, objdump, readelf
- References: <20080622061003.D279F3F303A@localhost>
csilvers@google.com (Craig Silverstein) writes:
> Index: bfd/elfxx-mips.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elfxx-mips.c,v
> retrieving revision 1.230
> diff -u -r1.230 elfxx-mips.c
> --- bfd/elfxx-mips.c 21 Apr 2008 17:54:24 -0000 1.230
> +++ bfd/elfxx-mips.c 22 Jun 2008 05:40:40 -0000
> @@ -5701,7 +5701,8 @@
> return FALSE;
> break;
> case SHT_MIPS_DWARF:
> - if (! CONST_STRNEQ (name, ".debug_"))
> + if (! CONST_STRNEQ (name, ".debug_")
> + && ! CONST_STRNEQ (name, ".zdebug_")
That's missing a paren. Committed as obvious.
Andreas.
2008-07-10 Andreas Schwab <schwab@suse.de>
* elfxx-mips.c (_bfd_mips_elf_section_from_shdr): Add missing
paren.
--- elfxx-mips.c.~1.231.~ 2008-07-10 09:54:11.000000000 +0200
+++ elfxx-mips.c 2008-07-10 18:17:58.000000000 +0200
@@ -5702,7 +5702,7 @@ _bfd_mips_elf_section_from_shdr (bfd *ab
break;
case SHT_MIPS_DWARF:
if (! CONST_STRNEQ (name, ".debug_")
- && ! CONST_STRNEQ (name, ".zdebug_")
+ && ! CONST_STRNEQ (name, ".zdebug_"))
return FALSE;
break;
case SHT_MIPS_SYMBOL_LIB:
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."