This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: support compressed sections in addr2line, objdump, readelf
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: csilvers at google dot com
- Cc: schwab at suse dot de, nickc at redhat dot com, binutils at sourceware dot org
- Date: Thu, 10 Jul 2008 22:25:15 +0200
- Subject: Re: PATCH: support compressed sections in addr2line, objdump, readelf
> Date: Thu, 10 Jul 2008 11:43:19 -0700 (PDT)
> From: csilvers@google.com (Craig Silverstein)
> } Native configuration is powerpc-suse-linux-gnu
> } [...]
> } regexp_diff match failure
> } regexp "^ Minimum Instruction Length: 1$"
> } line " Minimum Instruction Length: 4"
> } FAIL: objdump -W
>
> Thanks for the bug report. It's very possible the bug is with the
> test: I don't know which parts of the debug output are always the same
> between architectures, and which might differ. Is anyone on this list
> a powerpc expert?
(Do you mean "is 4 the correct value for powerpc"? Dunno, but
it's certainly consistent with the tc-ppc.h value for
DWARF2_LINE_MIN_INSN_LENGTH. :)
> Is it reasonable that the "Minimum Instruction
> Length" field (in the .debug_line debug section) might be 1 on some
> architectures and >1 on others?
Uh, yes. It's 2 for CRIS; all insns are a multiple of 2 bytes
long.
> Andreas, if you manually change the objdump.W to fix up the failing
> line, does the rest of the file match?
It does for me. I'd commit this fix as obvious...except there
are *two* "Minimum Instruction Length:" lines in objdump.W, and
the first one matches 1. What's going on? Is there a bug here?
* binutils-all/objdump.W: Generealize to adjust for
targets with non-byte-size instructions.
Index: binutils-all/objdump.W
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/objdump.W,v
retrieving revision 1.1
diff -p -u -r1.1 objdump.W
--- binutils-all/objdump.W 10 Jul 2008 01:32:23 -0000 1.1
+++ binutils-all/objdump.W 10 Jul 2008 20:21:38 -0000
@@ -77,7 +77,7 @@ Raw dump of debug contents of section .d
Length: 25
DWARF Version: 2
Prologue Length: 19
- Minimum Instruction Length: 1
+ Minimum Instruction Length: [1248]
Initial value of 'is_stmt': 1
Line Base: -5
Line Range: 14
brgds, H-P