This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix mips_ip for correct error message


Hi Chao-Ying,

  In "mips_ip", the error handling code forgets to reset s to argsStart,
such that the instruction string is incomplete.

Good catch, but doesn't the same problem occur earlier on, ie line 8604:


	      if (save_c)
		*(--s) = save_c;
	      return;

Also there is no point in reassigning the value of the "s" variable when you can just use argsStart directly, ie:

        if (save_c)
          * argsStart = save_c;

Please could you try out two changes to see if any more tweaks are needed to the testsuite and then resubmit your patch.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]