This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH COMMITTED: print version number in error message
- From: csilvers at google dot com (Craig Silverstein)
- To: binutils at sourceware dot org
- Date: Mon, 21 Jul 2008 16:37:49 -0700 (PDT)
- Subject: PATCH COMMITTED: print version number in error message
I've committed the following patch to gold, to make an error message
more informative. It was approved by Ian Taylor.
craig
--cut here--
* symtab.cc (Symbol_table::warn_about_undefined_dynobj_symbol):
Include symbol version in error message.
Index: symtab.cc
===================================================================
RCS file: /cvs/src/src/gold/symtab.cc,v
retrieving revision 1.100
diff -u -r1.100 symtab.cc
--- symtab.cc 10 Jul 2008 23:01:20 -0000 1.100
+++ symtab.cc 18 Jul 2008 00:44:04 -0000
@@ -2341,9 +2341,17 @@
// A very ugly cast.
Dynobj* dynobj = static_cast<Dynobj*>(sym->object());
if (!dynobj->has_unknown_needed_entries())
- gold_error(_("%s: undefined reference to '%s'"),
- sym->object()->name().c_str(),
- sym->demangled_name().c_str());
+ {
+ if (sym->version())
+ gold_error(_("%s: undefined reference to '%s', version '%s'"),
+ sym->object()->name().c_str(),
+ sym->demangled_name().c_str(),
+ sym->version());
+ else
+ gold_error(_("%s: undefined reference to '%s'"),
+ sym->object()->name().c_str(),
+ sym->demangled_name().c_str());
+ }
}
}