This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH]: fail gas tests which expect an error but don't get an error


Hi,

if a test expects an error ("#error-output:" or "#error:" in the *.d 
file for run_dump_test), the test doesn't fail if gas doesn't report an 
error. This patch fixes this.

Ok to apply?

chris


gas/testsuite/ChangeLog:

2008-09-04  Christian Groessler  <chris@groessler.org>

	* lib/gas-defs.exp (run_dump_test): If the test expects an error,
	fail the test if gas doesn't report an error.




Index: gas-defs.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/lib/gas-defs.exp,v
retrieving revision 1.29
diff -u -r1.29 gas-defs.exp
--- gas-defs.exp        8 Jan 2008 08:37:13 -0000       1.29
+++ gas-defs.exp        4 Sep 2008 21:36:17 -0000
@@ -690,6 +690,10 @@
                return
            }
        }
+    } else {
+       if { $opts(error) != "" || $opts(error-output) != "" } {
+          fail $testname
+       }
     }
 
     if { $program == "" } {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]