This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Simplify handling of NOPOWER4 and mfcr


On Mon, Sep 08, 2008 at 08:00:22PM -0500, Peter Bergner wrote:
> --- gas/config/tc-ppc.c	2 Aug 2008 04:38:50 -0000	1.141
> +++ gas/config/tc-ppc.c	8 Sep 2008 22:48:17 -0000
> @@ -1428,15 +1428,8 @@ ppc_setup_opcodes (void)
>  	  && ((op->flags & PPC_OPCODE_BOOKE64) == 0
>  	      || (ppc_cpu & PPC_OPCODE_BOOKE64) == PPC_OPCODE_BOOKE64
>  	      || (ppc_cpu & PPC_OPCODE_BOOKE) == 0)
> -	  && ((op->flags & (PPC_OPCODE_POWER4 | PPC_OPCODE_NOPOWER4)) == 0
> -	      || ((op->flags & PPC_OPCODE_POWER4)
> -		  == (ppc_cpu & PPC_OPCODE_POWER4)))
> -	  && ((op->flags & PPC_OPCODE_POWER5) == 0
> -	      || ((op->flags & PPC_OPCODE_POWER5)
> -		  == (ppc_cpu & PPC_OPCODE_POWER5)))
> -	  && ((op->flags & PPC_OPCODE_POWER6) == 0
> -	      || ((op->flags & PPC_OPCODE_POWER6)
> -		  == (ppc_cpu & PPC_OPCODE_POWER6))))
> +	  && ((ppc_cpu & PPC_OPCODE_POWER4) == 0
> +	      || (op->flags & PPC_OPCODE_NOPOWER4) == 0))

Seems to me this will enable power4 instructions when ppc_cpu says
otherwise.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]