This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/6931: COMDAT group is broken


On Fri, Oct 03, 2008 at 07:16:16PM +0930, Alan Modra wrote:
> Finally, I tweaked the various emulation's place_orphan code to not
> use an existing output section statement if it did not already have a
> bfd section.  This is because a new bfd section will be created after
> all other existing sections, which is probably the wrong ordering.
> lang_place_orphan knows how to rearrange sections.

One testcase expected the wrong order.

	* ld-powerpc/vxworks1-lib.rd: Update.

Index: ld/testsuite/ld-powerpc/vxworks1-lib.rd
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-powerpc/vxworks1-lib.rd,v
retrieving revision 1.4
diff -u -p -r1.4 vxworks1-lib.rd
--- ld/testsuite/ld-powerpc/vxworks1-lib.rd	15 May 2007 12:22:34 -0000	1.4
+++ ld/testsuite/ld-powerpc/vxworks1-lib.rd	3 Oct 2008 12:59:44 -0000
@@ -1,9 +1,4 @@
 
-Relocation section '\.rela\.plt' at offset .* contains 2 entries:
- Offset     Info    Type            Sym\.Value  Sym\. Name \+ Addend
-0009040c  .*15 R_PPC_JMP_SLOT    00000000   sexternal \+ 0
-00090410  .*15 R_PPC_JMP_SLOT    00080c48   sglobal \+ 0
-
 Relocation section '\.rela\.dyn' at offset .* contains 5 entries:
  Offset     Info    Type            Sym\.Value  Sym\. Name \+ Addend
 00090800  00000016 R_PPC_RELATIVE * 00080c44
@@ -11,3 +6,8 @@ Relocation section '\.rela\.dyn' at offs
 00080c12  .*04 R_PPC_ADDR16_LO   00000000   __GOTT_BASE__ \+ 0
 00080c16  .*03 R_PPC_ADDR16      00000000   __GOTT_INDEX__ \+ 0
 00090414  .*14 R_PPC_GLOB_DAT    00090c00   x \+ 0
+
+Relocation section '\.rela\.plt' at offset .* contains 2 entries:
+ Offset     Info    Type            Sym\.Value  Sym\. Name \+ Addend
+0009040c  .*15 R_PPC_JMP_SLOT    00000000   sexternal \+ 0
+00090410  .*15 R_PPC_JMP_SLOT    00080c48   sglobal \+ 0

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]