This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
FYI: fix build for gcc 4.4
- From: Tom Tromey <tromey at redhat dot com>
- To: Binutils Development <binutils at sourceware dot org>
- Date: Tue, 09 Dec 2008 11:58:20 -0700
- Subject: FYI: fix build for gcc 4.4
- Reply-to: tromey at redhat dot com
I did a binutils build using a recent gcc trunk today. It died in a
couple of places due to a couple of -Wparentheses violations.
The appended patch fixes these two spots. I'm committing this as
obvious.
Tom
2008-12-09 Tom Tromey <tromey@redhat.com>
* pef.c (bfd_pef_parse_traceback_table): Add parens to placate gcc
4.4.
2008-12-09 Tom Tromey <tromey@redhat.com>
* srconv.c (wr_hd): Add parens to placate gcc 4.4.
Index: bfd/pef.c
===================================================================
RCS file: /cvs/src/src/bfd/pef.c,v
retrieving revision 1.24
diff -u -r1.24 pef.c
--- bfd/pef.c 30 Jul 2008 04:34:56 -0000 1.24
+++ bfd/pef.c 9 Dec 2008 18:53:50 -0000
@@ -97,7 +97,7 @@
if (! (table.flags2 & TB_NAME_PRESENT))
return -1;
- if (! table.flags1 & TB_HAS_TBOFF)
+ if (! (table.flags1 & TB_HAS_TBOFF))
return -1;
offset = 8;
Index: binutils/srconv.c
===================================================================
RCS file: /cvs/src/src/binutils/srconv.c,v
retrieving revision 1.24
diff -u -r1.24 srconv.c
--- binutils/srconv.c 15 Oct 2007 02:00:56 -0000 1.24
+++ binutils/srconv.c 9 Dec 2008 18:53:50 -0000
@@ -1,6 +1,6 @@
/* srconv.c -- Sysroff conversion program
Copyright 1994, 1995, 1996, 1998, 1999, 2000, 2001, 2002, 2003, 2004,
- 2005, 2007 Free Software Foundation, Inc.
+ 2005, 2007, 2008 Free Software Foundation, Inc.
This file is part of GNU Binutils.
@@ -415,7 +415,7 @@
abort ();
}
- if (! bfd_get_file_flags(abfd) & EXEC_P)
+ if (! (bfd_get_file_flags(abfd) & EXEC_P))
{
hd.ep = 0;
}