This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Committed: fix another wrong .size expression in the ld testsuite
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sourceware dot org
- Date: Mon, 15 Dec 2008 02:31:14 +0100
- Subject: Committed: fix another wrong .size expression in the ld testsuite
Doh again, those are easy to get wrong.
TODO: an option to gas for pedantic .size checking:
- that the first operand is a global (the previous globalized) symbol
- that the second operand is a constant or a first-pass reducible
expression (defined prior to the use) between local symbols in
the same section, and in the same section as the first operand.
Committed.
* ld-cris/got7.s: Correct .size expression.
* ld-cris/tls-e-20a.d: Adjust accordingly.
Index: ld-cris/got7.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/got7.s,v
retrieving revision 1.1
diff -p -u -r1.1 got7.s
--- ld-cris/got7.s 25 Nov 2008 04:10:47 -0000 1.1
+++ ld-cris/got7.s 14 Dec 2008 23:43:35 -0000
@@ -9,7 +9,7 @@ got7fn:
move.d got7var\n:GOT,$r10
.endr
.Lfe:
- .size dsofn5,.Lfe-got7fn
+ .size got7fn,.Lfe-got7fn
.irpc n,1234567
.data
Index: ld-cris/tls-e-20a.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-cris/tls-e-20a.d,v
retrieving revision 1.1
diff -p -u -r1.1 tls-e-20a.d
--- ld-cris/tls-e-20a.d 25 Nov 2008 04:10:47 -0000 1.1
+++ ld-cris/tls-e-20a.d 14 Dec 2008 23:43:35 -0000
@@ -48,7 +48,7 @@ SYMBOL TABLE:
0+88 g \.tdata 0+4 \.hidden x2
0+821ac g O \.data 0+4 got7var3
0+821bc g O \.data 0+4 got7var7
-0+80098 g F \.text 0+ got7fn
+0+80098 g F \.text 0+2a got7fn
0+821b8 g O \.data 0+4 got7var6
0+80094 g \.text 0+ _start
0+821c0 g \*ABS\* 0+ __bss_start
brgds, H-P