This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
2009/1/1 Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>: > On Thu, Jan 01, 2009 at 06:55:59PM +0100, Kai Tietz wrote: >>2009/1/1 Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>: >>> On Thu, Jan 01, 2009 at 04:58:26PM +0100, Kai Tietz wrote: >>>>this patch fixes a problem about wince and the windres tool. >>>> >>>>ChangeLog >>>> >>>>2009-01-01 Kai Tietz <kai.tietz@onevision.com> >>>> >>>> * windres.c (set_endianess): Cut name between '-' for search. >>>> >>>>I tested this patch on mingwce and on x86_64-pc-mingw32. >>>> >>>>Is it ok for apply? >>> >>> I don't think so. You need to provide more details about what you're fixing. >>> >>> You shouldn't use "l" (ell) as a variable name because, IMO, it looks >>> too much like a 1 (one). >>> >>> And you really, really shouldn't introduce a ^M into source files. >>> >>> Couldn't you use alloca here to allocate new_tname and avoid a xmalloc? >>> >>> cgf >>> >> >>The ^M I haven't removed by accident. The (el)l variable I rename. >>Hmm, well alloca would be possible too. But isn't the scope of >>validity of stack just within the current frame, and not necessarily >>out side of it? This was the reason why I used xmalloc/free here. > > AFAIK, The stack frame of the caller would be the duration of the > function call. > > I probably missed this in a previous message but can you show the > target triple that this is supposed to be adapted to? E.g. "pe-arm-wince-little" I attached corrected patch. Cheers, Kai -- | (\_/) This is Bunny. Copy and paste | (='.'=) Bunny into your signature to help | (")_(") him gain world domination
Attachment:
wince_windres.diff
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |