This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Deprecating ppc opcodes


On Wed, 2009-01-07 at 11:16 +1030, Alan Modra wrote:
> On Thu, Dec 18, 2008 at 05:45:01PM -0600, Peter Bergner wrote:
> > Alan,
> > 
> > While working on the full POWER7 binutils, I noticed the L field of the
> > fre instruction has been deprecated.  Looking at how we deprecate opcodes
> > in the assembler, I see we have the NOPOWER4 macro which tells us it's not
> > supported on POWER4.  For fre, it would seem I would need to define a
> > NOPOWER7 macro.  However, the problem with that method is that it eats up
> > bits in the opcode flag field.  Instead, would creating a deprecated field
> > in struct ppc_opcode which would state when a opcode is no longer supported
> > like the code below be acceptable?
> 
> Hi Peter,
>   The patch is fine to commit with a changelog entry.

Thanks.  Below is the ChangeLog entry I used.

Peter


gas/
	* config/tc-ppc.c (ppc_setup_opcodes): Remove PPC_OPCODE_NOPOWER4 test.
	Test the new "deprecated" opcode field.

include/opcode/
	* ppc.h (struct powerpc_opcode): New field "deprecated".
	(PPC_OPCODE_NOPOWER4): Delete.

opcodes/
	* ppc-opc.c (PPCNONE): Define.
	(NOPOWER4): Delete.
	(powerpc_opcodes): Initialize the new "deprecated" field.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]