This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] S/390: Define LOCAL_LABEL_PREFIX
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: binutils at sourceware dot org
- Date: Wed, 14 Jan 2009 16:38:50 +0100
- Subject: Re: [PATCH] S/390: Define LOCAL_LABEL_PREFIX
- References: <20090114093512.GA14849@bart> <jetz82p65l.fsf@sykes.suse.de>
Hi Andreas,
* config/tc-s390.h: Define LOCAL_LABEL_PREFIX.
Why only s390? Almost no other ELF target defines that.
at least for i386 I can say that these as-generated labels (Lx^By) are
always replaced with section symbol + offset. Returning 0 in the
tc_i386_fix_adjustable hook makes the Lx^By symbols appear in the symbol
table. And I think they also for i386 should better start with a '.' in
order to make them recognizable as local symbols.
I'm not sure why the adjustment of the symbols isn't done for S/390. You
pointed me to a patch from Martin which changed the behavior of the hook
preventing the adjustment. Perhaps Martin could shed some light on this?!
http://sourceware.org/ml/binutils/2002-07/msg00036.html
Regardless of the adjustment happening or not I think the change is
correct since local symbols on S/390 in fact start with a '.' and that's
basically all the macro says.
Bye,
-Andreas-