This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch]: Correct interpretation of IMAGE_SCN_MEM_DISCARDABLE in coffcode.h
- From: Nick Clifton <nickc at redhat dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Danny Smith <dansmister at gmail dot com>, Binutils <binutils at sourceware dot org>, Kai Tietz <ktietz70 at googlemail dot com>
- Date: Fri, 16 Jan 2009 10:22:12 +0000
- Subject: Re: [patch]: Correct interpretation of IMAGE_SCN_MEM_DISCARDABLE in coffcode.h
- References: <OFC29AAB0E.66D8C19E-ONC125753C.003BA98F-C125753C.003C8306@onevision.de>
Hi Kai,
Thank you for giving me a hint. I altered the patch, so that it sets
DEBUGGING for .debug*, .stab*, .comment, and .gnu.linkonce.wi.* sections.
Ok, for apply?
Approved - please apply; except - please could you adjust the wording of
the comment slightly. Instead of:
/* The MS PE spec says, that debug sections are DISCARDABLE,
but the DISCARDABLE flag has not the meaning of being debug.
So just set SEC_DEBUGGING for them. */
please could we have:
/* The MS PE spec says that debug sections are DISCARDABLE,
but the presence of a DISCARDABLE flag does not necessarily
mean that a given section contains debug information. Thus
we only set the SEC_DEBUGGING flag on sections that we
recognise as containing debug information. */
Cheers
Nick