This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] S/390: Define LOCAL_LABEL_PREFIX
Andreas Schwab <schwab@suse.de> writes:
> Ian Lance Taylor <iant@google.com> writes:
>
>> Andreas Schwab <schwab@suse.de> writes:
>>
>>> Andreas Kranz <andikr@gmx.net> writes:
>>>
>>>>> My point is that this is not a s390 thing, but an ELF thing. It should
>>>>> be a generic ELF setting, consistent with BFD.
>>>>
>>>> Ok. How about bfd/elf-bfd.h?
>>>
>>> I don't think that's the right place to define it, it should rather be
>>> in gas/obj-elf.h.
>>
>> Note that that has a different effect with regard to the linker's
>> --discard-locals option.
>
> Can you expand? How does this affect the linker?
I'm sorry, you're right, it doesn't. I was thinking of something
else.
In the ELF linker, a local label is determined by
_bfd_elf_is_local_label_name in bfd/elf.c. That checks for a ".L"
prefix. gas should be consistent.
Ian