Re: Question about your patch

[Nick Clifton <nickc at redhat dot com>]

Hi Catherine,

> old part:
> !                       if ((sec->flags & SEC_ALLOC) != 0
> !                           /* BPABI objects never have dynamic
> !                              relocations mapped.  */
> !                           && !htab->symbian_p)
> !                         flags |= SEC_ALLOC | SEC_LOAD;

> new part:
> !                   /* BPABI objects never have dynamic relocations 
> mapped.  */
> !                   if (! htab->symbian_p)
>                       {
> !                       flagword flags;
>
> !                       flags = bfd_get_section_flags (dynobj, sreloc);
> !                       flags &= ~(SEC_LOAD | SEC_ALLOC);
> !                       bfd_set_section_flags (dynobj, sreloc, flags);


> What I'm seeing is that the SEC_ALLOC flag is missing for .rel.somename 
> sections that are created, which in turn is causing these sections to be 
> emitted to the output bfd instead of being placed in the .rel.dyn 
> section.  In particular, it's happening during the building of libc.so 
> for arm-linux. Did you mean to make that change to the flags to prevent 
> the SEC_ALLOC flag from being set?

Nope - that is what they technically call a bug ... :-)  Sorry about 
that.  Presumably you have a patch that fixes this ?  If not please 
consider it pre-approved, otherwise I'll write one myself.

Cheers
  Nick