This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch]: Regression in windres
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: Kai Tietz <ktietz70 at googlemail dot com>, Binutils <binutils at sourceware dot org>
- Date: Fri, 6 Feb 2009 18:09:28 -0500
- Subject: Re: [patch]: Regression in windres
- References: <90baa01f0902061054y3e95b5e4w43f01cb51f8a945f@mail.gmail.com>
On Fri, Feb 06, 2009 at 07:54:32PM +0100, Kai Tietz wrote:
>Hello,
>
>I noticed a typo in my last change of windres.
>
>ChangeLog
>
>2009-02-06 Kai Tietz <kai.tietz@onevision.com>
>
> * windres.c (set_endianess): Copy name without leading '-'.
>
>Is this patch ok for apply?
Looking at this with greater context, couldn't you just achieve the same thing by
using a "tname = ++hyp" a few lines above this? That avoids having to calculate
hyp + 1 twice.
cgf
Index: windres.c
===================================================================
RCS file: /cvs/src/src/binutils/windres.c,v
retrieving revision 1.37
diff -d -u -r1.37 windres.c
--- windres.c 6 Jan 2009 15:36:05 -0000 1.37
+++ windres.c 6 Feb 2009 23:08:58 -0000
@@ -1102,7 +1102,7 @@
if (hyp != NULL)
{
- tname = hyp + 1;
+ tname = ++hyp;
/* Make sure we dectect architecture names
for triplets like "pe-arm-wince-little". */