This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gold][patch] Small code refactoring


I was playing with gold and found a bit of code duplication. The
attached patch removes it. I tested this with "make check" in the gold
directory. Is there some other test I should do?

 6 files changed, 64 insertions(+), 76 deletions(-)

2009-02-12  Rafael Avila de Espindola  <espindola@google.com>

	* archive.cc (Archive::get_elf_object_for_member): Update for
	new make_elf_object signature.
	* object.cc (make_elf_object): Rename to make_elf_object2. Make it
	static.
	(make_elf_object): New.
	* object.h (make_elf_object): Update signature.
	* readsyms.cc (Read_symbols::do_read_symbols): Update for
	new make_elf_object signature.
	* testsuite/binary_unittest.cc (Sized_binary_test): Update for
	new make_elf_object signature.
	* testsuite/object_unittest.cc (Sized_object_test): Update for
	new make_elf_object signature.

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]