This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ARM long branch stub: pic

On 18.02.2009 17:27, Daniel Jacobowitz wrote:
On Wed, Feb 18, 2009 at 04:22:21PM +0100, Christophe LYON wrote:
Note that the current PIC stub is not correct (it uses a target address rather than an offset), I will send a separate patch for this later. 

I don't understand - it looks like an offset to me.  I'll wait to see
your next patch.

Sorry I was confused by the buffers I was looking at and didn't describe the right thing. It's more that I think that in some combinations, the stub codes use instructions not available on older architectures.

This is OK.  Please change "R_ARM_REL32(X)" to "R_ARM_REL32(X-4)" in
the comment in the stub.

Thanks, committed.


Christophe.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]