This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] Use .set instead of .equ in localize hidden tests
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: binutils at sourceware dot org
- Date: Sun, 1 Mar 2009 14:17:39 -0500 (EST)
- Subject: [PATCH] Use .set instead of .equ in localize hidden tests
The tests localize-hidden-1.s and localize-hidden-2.s fail to assemble
on hppa because .equ requires a label. Thus, I would like to change
.equ to .set in these tests.
The result has been tested on x86_64-unknown-linux-gnu with no regressions.
I also ran the tests on hppa64-hp-hpux11.11 and hppa-unknown-linux-gnu.
Both these targets fail localize-hidden-1.s (binutils PR 3807).
localize-hidden-2.s passes.
Ok to commit?
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)
2009-03-01 John David Anglin <dave.anglin@nrc-cnrc.gc.ca>
* binutils-all/localize-hidden-1.s: Change .equ to .set.
* binutils-all/localize-hidden-2.s: Likewise.
Index: binutils-all/localize-hidden-1.s
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/localize-hidden-1.s,v
retrieving revision 1.2
diff -u -3 -p -r1.2 localize-hidden-1.s
--- binutils-all/localize-hidden-1.s 23 Jun 2006 16:23:09 -0000 1.2
+++ binutils-all/localize-hidden-1.s 1 Mar 2009 18:42:23 -0000
@@ -20,17 +20,17 @@
.protected Gprotected
.protected Wprotected
- .equ Ldefault, 0x1100
- .equ Lhidden, 0x1200
- .equ Linternal, 0x1300
- .equ Lprotected, 0x1400
+ .set Ldefault, 0x1100
+ .set Lhidden, 0x1200
+ .set Linternal, 0x1300
+ .set Lprotected, 0x1400
- .equ Gdefault, 0x2100
- .equ Ghidden, 0x2200
- .equ Ginternal, 0x2300
- .equ Gprotected, 0x2400
+ .set Gdefault, 0x2100
+ .set Ghidden, 0x2200
+ .set Ginternal, 0x2300
+ .set Gprotected, 0x2400
- .equ Wdefault, 0x3100
- .equ Whidden, 0x3200
- .equ Winternal, 0x3300
- .equ Wprotected, 0x3400
+ .set Wdefault, 0x3100
+ .set Whidden, 0x3200
+ .set Winternal, 0x3300
+ .set Wprotected, 0x3400
Index: binutils-all/localize-hidden-2.s
===================================================================
RCS file: /cvs/src/src/binutils/testsuite/binutils-all/localize-hidden-2.s,v
retrieving revision 1.2
diff -u -3 -p -r1.2 localize-hidden-2.s
--- binutils-all/localize-hidden-2.s 23 Jun 2006 16:23:09 -0000 1.2
+++ binutils-all/localize-hidden-2.s 1 Mar 2009 18:42:23 -0000
@@ -1,2 +1,2 @@
.globl G
- .equ G,0x100
+ .set G,0x100