This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] PowerPC E500mc support
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Edmar Wienskoski-RA8797 <edmar at freescale dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 01 Apr 2009 19:46:34 -0500
- Subject: Re: [RFA] PowerPC E500mc support
- References: <1238611492.31613.ezmlm@sourceware.org> <1238612303.6851.21.camel@otta> <49D3E5E7.3070207@freescale.com>
On Wed, 2009-04-01 at 17:08 -0500, Edmar Wienskoski-RA8797 wrote:
> Peter Bergner wrote:
> > As part of your patch adding E500MC support, I see you added the following hunk:
> >
> > {"dcbzl", XOPL(31,1014,1), XRT_MASK, POWER4, {RA, RB}},
> > + {"dcbzl", XOPL(31,1014,1), XRT_MASK, NOPOWER4|E500MC,{RA, RB}},
> >
> > Shouldn't this hunk have looked like the following instead:
> >
> > {"dcbzl", XOPL(31,1014,1), XRT_MASK, POWER4|E500MC, {RA, RB}},
> >
> > ...or was there really supposed to be a difference between the POWER4 and
> > E500MC versions which you wanted to make but missed doing so?
> > If it's the former, I can add it to some changes I'm making further
> > cleaning up disassembly with -Many.
>
> I don't remember the details, but I do remember that POWER4 | E500MC did
> not build.
Ok, since it was just a build issue, I have checked in the following which
builds and make checks with no errors as obvious.
Peter
opcodes/
* ppc-opc.c (powerpc_opcodes) <"dcbzl">: Merge the POWER4 and
E500MC entries.
Index: opcodes/ppc-opc.c
===================================================================
RCS file: /cvs/src/src/opcodes/ppc-opc.c,v
retrieving revision 1.118
diff -u -p -r1.118 ppc-opc.c
--- opcodes/ppc-opc.c 4 Mar 2009 01:00:53 -0000 1.118
+++ opcodes/ppc-opc.c 2 Apr 2009 00:41:44 -0000
@@ -4725,8 +4725,7 @@ const struct powerpc_opcode powerpc_opco
{"dcbzep", XRT(31,1023,0), XRT_MASK, E500MC, PPCNONE, {RA, RB}},
-{"dcbzl", XOPL(31,1014,1), XRT_MASK, POWER4, PPCNONE, {RA, RB}},
-{"dcbzl", XOPL(31,1014,1), XRT_MASK, PPCCOM|E500MC,POWER4, {RA, RB}},
+{"dcbzl", XOPL(31,1014,1), XRT_MASK, POWER4|E500MC, PPCNONE, {RA, RB}},
{"cctpl", 0x7c210b78, 0xffffffff, CELL, PPCNONE, {0}},
{"cctpm", 0x7c421378, 0xffffffff, CELL, PPCNONE, {0}},