This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Warn alternate ELF machine code
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 8 Apr 2009 06:06:31 -0700
- Subject: Re: PATCH: Warn alternate ELF machine code
- References: <20090407201016.GA7727@lucon.org> <49DC8224.6090609@redhat.com>
On Wed, Apr 8, 2009 at 3:53 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi H.J.,
>
>> This patch adds an option, --warn-alternate-em, to issue a warning if
>> an object has alternate ELF machine code.
>
> What is the motivation for this feature ?
The alternate ELF machine codes are usually unofficial and temporary.
The official ELF machine code should be used if possible. This option
provides a way to identify which object files don't have the official
machine code.
>> + ? ?info->callbacks->einfo
>> + ? ? ?(_("%P: warning: alternate ELF machine code (%d): %B\n"),
>> + ? ? ? ehdr->e_machine, abfd);
>
> I think that the warning should be slightly more verbose. ?Something like:
>
> ?warning: alternate ELF machine code found (%d) in %B, expecting %d
>
OK for trunk with this change?
Thanks.
--
H.J.