Re: PATCH: Remove force_minimum_alignment and force_minimum_alignment

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Apr 17, 2009 at 3:19 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Since EFI targets are removed, we don't need force_minimum_alignment nor
> force_minimum_alignment anymore. This patch removes them. Also page size
> on Windows ia64 is 8K, not 4K:
>
> http://blogs.msdn.com/oldnewthing/archive/2004/09/08/226797.aspx
>
> Also we can't set D_PAGED, which is set by
>
> ?/* FIXME: How can we set D_PAGED correctly? ?*/
> ?if ((internal_f->f_flags & F_EXEC) != 0)
> ? ?abfd->flags |= D_PAGED;
>
> in coff_real_object_p, on a PEI target if PE section alignment is
> smaller than COFF_PAGE_SIZE. ?This patch also fixes it so that the
> section is layout correctly when
>
> ?--file-alignment=0x20 --section-alignment=0x20
>
> is used with objcopy. ?OK to install?

Here is the updated patch to remove PEI_TARGET_SUBSYSTEM
and PEI_FORCE_MINIMUM_ALIGNMENT from pei-ia64.c. OK
to install?

Thanks.

-- 
H.J.
---

2009-04-17  H.J. Lu  <hongjiu.lu@intel.com>

	* coff-ia64.c (COFF_PAGE_SIZE): Changed to 8K.
	
	* coffcode.h (coff_compute_section_file_positions): Clear
	D_PAGED if PE section alignment is smaller than COFF_PAGE_SIZE.

	* libcoff-in.h (pe_tdata): Remove force_minimum_alignment and
	force_minimum_alignment.

	* libcoff.h: Regenerated.

	* pei-ia64.c (PEI_TARGET_SUBSYSTEM): Removed.
	(PEI_FORCE_MINIMUM_ALIGNMENT): Likewise.

	* peicode.h (pe_mkobject): Don't set force_minimum_alignment
	nor target_subsystem.

	* peXXigen.c (_bfd_XXi_swap_aouthdr_out): Don't check
	force_minimum_alignment nor target_subsystem.

Attachment: bfd-pei-page-2.patch
Description: Text document