This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: create .gnu_incremental_inputs entries for inputs
- From: Ian Lance Taylor <iant at google dot com>
- To: Mikolaj Zalewski <mikolajz at google dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 15 May 2009 10:01:20 -0700
- Subject: Re: [PATCH] gold: create .gnu_incremental_inputs entries for inputs
- References: <7ebec9e70905111514k6a376d28o3c28070a512b290f@mail.gmail.com>
Mikolaj Zalewski <mikolajz@google.com> writes:
> This patch stores some data for inputs entries. It does not yet
> create entries for archive members, doesn't store the extra type
> specific information nor save the timestamp, but all this can be fixed
> later if the approach in this patch is good. A file added by a plugin
> is currently an error - I will look into plug-ins later.
> Incremental link needs more information about input element that I
> have found gold to save, so I'm storing the extra information in a map
> in Incremental_inputs. It could be added as extra fields to
> Input_argument, but then the structure wouldn't be immutable anymore
> and there would be a slight memory overhead for non-incremental
> builds.
I would consider simply adding a pointer to Input_argument, rather than
using Increment_inputs::inputs_map_. And I would use a union in
Incremental_inputs::Input_info. But this code is OK, and I committed it
with some formatting changes. Particular changes: two spaces after the
end of a sentence in a comment, and line up function arguments under
parentheses rather than using a four space continuation indent. Also,
the ChangeLog entry is a lot better, thanks, but the text should be
sentences with a capital letter and a period.
Thanks. Committed.
Ian