This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Fix RUNTESTFLAGS "foo.exp=bar" syntax for ld link tests.
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 18 May 2009 18:42:26 +0100
- Subject: Fix RUNTESTFLAGS "foo.exp=bar" syntax for ld link tests.
Hi all,
I just noticed that the RUNTESTFLAGS test-selector syntax isn't fully
implemented in the ld testsuite. Dump tests respect it, but link tests don't,
leading to this sort of behaviour:
admin@ubik /usr/build/obj-binutils
$ make -k check-ld RUNTESTFLAGS="-all pe.exp=foobar"
[ ... snips ... ]
=== ld tests ===
Schedule of variations:
unix
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /usr/build/src-binutils/ld/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /usr/build/src-binutils/ld/testsuite/ld-pe/pe.exp ...
PASS: .secrel32
PASS: Empty export table
=== ld Summary ===
# of expected passes 2
/usr/build/obj-binutils/ld/ld-new 2.19.51.20090517
The attached patch adds the missing check, and correctly filters the list of
tests.
ld/testsuite/ChangeLog:
* lib/ld-lib.exp (run_ld_link_tests): Filter test names against
runtests list.
Ok?
cheers,
DaveK
Index: ld/testsuite/lib/ld-lib.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/lib/ld-lib.exp,v
retrieving revision 1.62
diff -p -u -r1.62 ld-lib.exp
--- ld/testsuite/lib/ld-lib.exp 2 Apr 2009 09:34:22 -0000 1.62
+++ ld/testsuite/lib/ld-lib.exp 18 May 2009 15:56:37 -0000
@@ -1132,9 +1132,15 @@ proc run_ld_link_tests { ldtests } {
global env
global CC
global CFLAGS
+ global runtests
foreach testitem $ldtests {
set testname [lindex $testitem 0]
+
+ if ![runtest_file_p $runtests $testname] then {
+ continue
+ }
+
set ld_options [lindex $testitem 1]
set as_options [lindex $testitem 2]
set src_files [lindex $testitem 3]