This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Updated plugin support for bfd


On Tuesday 26 May 2009 09:33:30 Rafael Espindola wrote:
> > well you've done real testing, so i wont complain there.
>
> Actually, I was asked to do so in a previous code review. I have never
> coded on Solaris :-)
>
> >  if the code is going
> > to be copied verbatim to different places, perhaps it makes sense to make
> > a simple m4 file for it ?  maybe in the config/ subdir ?  then we wont
> > have to worry about changes in one place bit rotting in others ...
>
> Good point. The attached patch does just the code factoring. Is it OK?

actually, i was talking about the plugin code.  but that looks good too :).
-mike


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]