This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: Fix a minor bug in --exclude-libs.
Patch commited.
2009-05-26 Doug Kwan <dougkwan@google.com>
* options.cc (General_options::parse_exclude_libs). Fix a comment.
(General_options::check_excluded_libs): Strip off directories in
archive name before matching like GNU ld does.
* testsuite/Makefile.am (MOSTLYCLEANFILES,
exclude_libs_test_DEPENDENCIES): Add alt/libexclude_libs_test_3.a
(exclude_libs_test_LDFLAGS): Add linker option
-Wl,--exclude-libs,libexclude_libs_test_3
(exclude_libs_test_LADD): Add alt/libexclude_libs_test_3.a as
an explicit archive without using -l.
(alt/libexclude_libs_test_3.a): New make rule.
* testsuite/Makefile.in: Regenerate.
* testsuite/exclude_libs_test.c : Declare lib3_default().
(main): Call it.
* exclude_libs_test.sh: Add tests for alt/exclude_libs_test_3.a.
* exclude_libs_test_3.c: New file.
2009/5/19 Doug Kwan (Ãö®¶¼w) <dougkwan@google.com>:
> A few tests use the alt directory. I'll look at all the tests that
> use alt/ and fix as appropriate.
>
> -Doug
>
> 2009/5/19 Ian Lance Taylor <iant@google.com>:
>> "Doug Kwan (Ãö®¶¼w)" <dougkwan@google.com> writes:
>>
>>> 2009/5/19 Ian Lance Taylor <iant@google.com>:
>>>
>>>>> +alt/libexclude_libs_test_3.a: exclude_libs_test_3.o
>>>>> + $(TEST_AR) rc $@ $^
>>>>
>>>> Does this work if the directory "alt" has not already been created?
>>>
>>> I have to checked. If not, I'll fix it. I just copied what other tests do.
>>
>> Ah, it works because the alt/weak_undef_lib.so target creates the alt
>> subdirectory. Please do the same in your patch.
>> test -d alt || mkdir -p alt
>>
>> Ian
>>
>