This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Gold: Implement the '--discard-locals' and '-X' options.


"Doug Kwan (éæå)" <dougkwan@google.com> writes:

> 2009-06-05  Doug Kwan  <dougkwan@google.com>
>
>         * Makefile.am (CCFILES): Add target.cc.
>         * Makefile.in: Regenerate.
>         * i386.cc (class Target_i386): Define new virtual method to
>         override do_is_local_label_name in parent.
>         * object.cc (Sized_relobj::do_count_local_symbols): Discard
>         local symbols if --discard-locals or -X is given.
>         * options.h (class General_options): Declare new options
>         '--discard-locals' and '-X' for discarding locals.
>         * target.h (class Target): Define new methods is_local_label_name.
>         Declare new virtual method do_is_local_label_name.
>         * target.cc: New file.
>         * testsuite/Makefile.am (check_PROGRAMS): Add discard_locals_test.
>         (check_SCRIPTS): Add discard_locals_test.sh.
>         (check_DATA): Add discard_local_tests.syms.
>         (discard_locals_test_SOURCES, discard_locals_test_LDFLAGS): Define.
>         (discard_local_tests.syms, discard_locals_test.o): New make rules.
>         * testsuite/Makefile.in: Regenerate.
>         * testsuite/discard_locals_test.c: New file.
>         * testsuite/discard_locals_test.sh: Same.

> +/* local symbol format for generic ELF target. */
> +asm (".Lshould_be_discarded:");
> +
> +#ifdef __i386__
> +/* additional local symbol format for the i386 target. */
> +asm (".Xshould_be_discarded:");
> +#endif

Capitalize the sentences in the comments.

OK with that change.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]