This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][ARM]. Fix a 64-bit portability bug in cortex_a8_erratum_scan.


I did not really cast all constant operands in offset related
expressions.  I think this ChangeLog entry is more accurate.

2009-06-11  Doug Kwan  <dougkwan@google.com>

        * elf32-arm.c (cortex_a8_erratum_scan): Change type of offset
        to bfd_signed_vma.  Cast constant operands which are used in
        offset related expressions to bfd_signed_vma type as appropriate.


2009/6/11 Doug Kwan (Ãö®¶¼w) <dougkwan@google.com>:
> This patch fixes a 64-bit portability bug in the cortex-a8 erratum
> workaround code that causes the test-case cortex-a8-fix-blx to fail on
> an x86_64 host.  I tested this patch on both 32-bit and 64-bit builds
> of an arm-none-eabi binutils on an x86_64-unknown-linux-gnu host.  All
> the linker test-cases passed.
>
> -Doug
>
> 2009-06-11  Doug Kwan  <dougkwan@google.com>
>
>        * elf32-arm.c (cortex_a8_erratum_scan): Change type of offset
>        to bfd_signed_vma.  Cast all constant operands which are used
>        in offset related expressions to bfd_signed_vma type.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]