This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: linker crash in arm stub generation

From: Daniel Jacobowitz <drow at false dot org>
To: Christophe LYON <christophe dot lyon at st dot com>
Cc: Nick Clifton <nickc at redhat dot com>, Phil Blundell <pb at reciva dot com>, binutils at sourceware dot org
Date: Fri, 12 Jun 2009 10:06:42 -0400
Subject: Re: linker crash in arm stub generation
References: <1244740179.21585.119.camel@mill.internal.reciva.com> <4A324BAC.7090702@redhat.com> <4A3255D9.9030906@st.com>

On Fri, Jun 12, 2009 at 03:19:21PM +0200, Christophe LYON wrote:
> I think your patch is not adequate: it will prevent the stub code from  
> being generated, but the user code will still jump to the stub. So the  
> link won't fail, but the result will be wrong.
>
> Instead, I propose this patch, which prevents mode-switching stub  
> generation when the call goes through a PLT entry.
>
> I think there should already be a test for this in the testsuite, I have  
> probably forgotten this configuration.

This looks good to me - and I agree that a test would be helpful!

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: linker crash in arm stub generation
  - From: Christophe LYON

References:
- linker crash in arm stub generation
  - From: Phil Blundell
- Re: linker crash in arm stub generation
  - From: Nick Clifton
- Re: linker crash in arm stub generation
  - From: Christophe LYON

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]