This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch testsuite ld]: Various fixes for the x86_64 pe target


2009/6/25 Dave Korn <dave.korn.cygwin@googlemail.com>:
> Kai Tietz wrote:
>
>> while running the testsuite I found some new issues for the
>> x86_64-*-mingw32 target and prepared a small patch to fix them (plus some
>> old one, too).
>
> ?Please when sending a patch don't use an imprecise description like "some
> new issues", at least a quick summary of the problem(s) would make it more
> immediately obvious how the patch solves it/them and save on requests for
> clarification.
>
>> ? ? ? ? * ld-pe/aligncomm-1.c (size_t): Add type.
>
> ?"type" -> "typedef" please.
>
>> ? ? ? ? (main): use it for casting pointer to scalar.
>
> ?Missing capitalisation.
>
>> ? ? ? ? * ld-pe/aligncomm-2.c: Likewise.
>> ? ? ? ? * ld-pe/aligncomm-3.c: Likewise.
>> ? ? ? ? * ld-pe/aligncomm-4.c: Likewise.
>> ? ? ? ? * ld-scripts/empty-address.exp: Make sure that for x86_64-*-mingw*
>> ? ? ? ? target imagebase is set to zero.
>> ? ? ? ? * ld-scripts/weak.exp: Don't fail for x86_64-*-mingw* target.
>>
>> Regression tested for i686-pc-mingw32 and x86_64-pc-mingw32. Ok for apply?
>
> ?OK, but do please explain what's going on in the aligncomm patches. ?Are you
> getting a signedness or precision-loss warning that you want to fix?
>
> ? ?cheers,
> ? ? ?DaveK
>

Casting a pointer to the type 'int' on 64-bit systems in general leads
to "warning: cast from pointer to integer of different size".
Therefore, before casting a pointer to integer scalar, you have to
convert it into a pointer-sized scalar (__SIZE_TYPE__ as gcc defines
it).

I thought those fixes were pretty obvious here, sorry to use to lax
description in mail header.

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]