This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/10337: strip breaks statically linked binaries with .rela.plt section
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 30 Jun 2009 10:21:36 +0930
- Subject: Re: PATCH: PR ld/10337: strip breaks statically linked binaries with .rela.plt section
- References: <20090627155720.GA21031@lucon.org>
On Sat, Jun 27, 2009 at 08:57:20AM -0700, H.J. Lu wrote:
> 2. We use
>
> hdr->sh_link != elf_onesymtab (abfd)
>
> to check if sh_link points to the main symbol table. But SHN_UNDEF
> will never be the main symbol table.
>
> This patch fixes it with a testcase. I will check it in as an obvious
> fix.
I think this change is wrong. If you treat relocation sections as
normal sections then you lose all the special BFD processing of
relocs. For example, objcopy --adjust-vma on an executable will not
modify reloc addresses for you. How hard is it to support reloc
sections with no associated symbol table?
--
Alan Modra
Australia Development Lab, IBM