This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: Don't chck static non-ifunc-using executable
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sources dot redhat dot com
- Cc: nickc at redhat dot com
- Date: Fri, 10 Jul 2009 12:31:13 -0700
- Subject: PATCH: Don't chck static non-ifunc-using executable
Hi,
Static non-ifunc-using executable check will fail if libc.a has
has ifunc functons. I am checking in this patch to disable it.
The proper check is to use default_ld_simple_link without using
any additional libraries.
H.J.
---
Index: ChangeLog
===================================================================
--- ChangeLog (revision 6375)
+++ ChangeLog (working copy)
@@ -1,5 +1,10 @@
2009-07-10 H.J. Lu <hongjiu.lu@intel.com>
+ * ld-ifunc/ifunc.exp: Don't chck static non-ifunc-using
+ executable.
+
+2009-07-10 H.J. Lu <hongjiu.lu@intel.com>
+
* ld-ifunc/ifunc-1-local-x86.d: Updated.
* ld-ifunc/ifunc-1-x86.d: Likewise.
* ld-ifunc/ifunc-3a-x86.d: Likewise.
Index: ld-ifunc/ifunc.exp
===================================================================
--- ld-ifunc/ifunc.exp (revision 6375)
+++ ld-ifunc/ifunc.exp (working copy)
@@ -241,10 +241,11 @@ if {! [check_osabi tmpdir/dynamic_prog {
fail "Dynamic ifunc-using executable does not have an OS/ABI field of LINUX"
set fails [expr $fails + 1]
}
-if {! [check_osabi tmpdir/static_nonifunc_prog {UNIX - System V}]} {
- fail "Static non-ifunc-using executable does not have an OS/ABI field of System V"
- set fails [expr $fails + 1]
-}
+# FIXME: This test will fail if libc.a has ifunc functons.
+#if {! [check_osabi tmpdir/static_nonifunc_prog {UNIX - System V}]} {
+# fail "Static non-ifunc-using executable does not have an OS/ABI field of System V"
+# set fails [expr $fails + 1]
+#}
# The linked ifunc using executables and the shared library containing
# ifunc should contain an IFUNC symbol. The non-ifunc using executable