This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] give .comment sections SHF_MERGE|SHF_STRINGS

From: Richard Henderson <rth at redhat dot com>
To: Roland McGrath <roland at redhat dot com>
Cc: Mark Wielaard <mjw at redhat dot com>, binutils at sources dot redhat dot com, Andreas Schwab <schwab at redhat dot com>, Nick Clifton <nickc at redhat dot com>
Date: Fri, 24 Jul 2009 16:39:19 -0700
Subject: Re: [PATCH] give .comment sections SHF_MERGE|SHF_STRINGS
References: <20090724190834.36DC23CCB@magilla.sf.frob.com> <1248474206.3517.9.camel@springer.wildebeest.org> <20090724223806.D70F7E7EA@magilla.sf.frob.com>

On 07/24/2009 03:38 PM, Roland McGrath wrote:

It only seems to work if I explicitly set the section entsize to 1.


Oh, I guess that's reasonable enough.  So I take this to mean you've tested
this version and declare it good?

Ok to commit tested version?

2009-07-24  Roland McGrath<roland@redhat.com>
	Mark Wielaard<mjw@redhat.com>

	* config/obj-elf.c (obj_elf_ident): Set SEC_MERGE | SEC_STRINGS
	flags on .comment section.

Ok.

r~

Follow-Ups:
- [COMMITTED-PATCH] give .comment sections SHF_MERGE|SHF_STRINGS
  - From: Roland McGrath

References:
- [PATCH] give .comment sections SHF_MERGE|SHF_STRINGS
  - From: Roland McGrath
- Re: [PATCH] give .comment sections SHF_MERGE|SHF_STRINGS
  - From: Mark Wielaard
- Re: [PATCH] give .comment sections SHF_MERGE|SHF_STRINGS
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]