This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support Xilinx MicroBlaze processor - patch 2


Joseph S. Myers wrote:
There seem to be various GNU Coding Standards violations in this code. Functions in microblaze-dis.c seem generally to be missing comment them, and there are lots of function calls without a space between the function name and opening parenthesis. Code formatting such as

+  if (inst == 0) {
+    return -1;
+  }

does not follow the standards for placing "{" either. This patch also has C++ comments.

I'll replace C++ comments and check code formatting.



-- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]