This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][GOLD] Add a PT_ARM_EXIDX segment for the .ARM.exidx section.


"Doug Kwan (éæå)" <dougkwan@google.com> writes:

>     This patch add a PT_ARM_EXIDX segment in the program header when
> there is a .ARM.exidx of type SHT_ARM_EXIDX unless we want relocatable
> linking or any PHDRS clauses are present in a script.    This is done
> in layout.cc mainly for simplity.  I am more than happy to move this
> to arm.cc and define a target hook if there is a better approach.

I think it would work to do this in
Target_arm<big_endian>::do_finalize_sections.

> +	  gold_assert(!find_output_segment(elfcpp::PT_ARM_EXIDX, 0, 0));

Note that find_output_segment does not return a bool, so this should be
    layout->find_output_segment(...) != NULL

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]