Re: PATCH: PR gas/10531: Strange assembler warning message on section group

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Aug 17, 2009 at 8:12 PM, Alan Modra<amodra@bigpond.net.au> wrote:
> On Mon, Aug 17, 2009 at 04:07:21PM -0700, H.J. Lu wrote:
>> We can't use bfd_get_section_by_name, subseg_new and subseg_get directly
>> in dwarf2dbg.c since they don't know ELF section groups. ?This patch adds
>> obj_get_section_by_name, obj_subseg_new and obj_subseg_get. ?Tested on
>> Linux/ia32, Linux/ia64 and Linux/Intel64. ?OK to install?
>
> Have you tested this with a multi-obj assembler? ?I suspect that
> something like x86-as --em=i386coff --gdwarf-2 will attempt to
> access elf-only data structures. ?(That's a slightly ridiculous
> set of command line options for x86, but we shouldn't have gas
> segfault.) ?I think the proper patch needs some new fields in
> struct format_ops and defines in obj-multi.h.
>

strcmp can't be used to check if 2 ELF sections have the same name.
I added bfd_section_name_eq.  OK to install?

Thanks.

-- 
H.J.
---
bfd/

2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	 PR gas/10531
	 * section.c: Include "elf-bfd.h".
	 (bfd_section_name_eq): New.
	 (bfd_get_section_by_name): Don't use a section in a section
	 group.
	 (bfd_make_section_old_way): Likewise.

	* bfd-in2.h: Regenerated.

gas/

2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	 PR gas/10531
	 * ehopt.c (get_cie_info): Use bfd_section_name_eq to check if
	 section names are the same.
	 (check_eh_frame): Likewise.
	 * read.c (emit_expr): Likewise.
	 (stringer): Likewise.
	 * stabs.c (s_stab_generic): Likewise.
	 * subsegs.c (subseg_get): Likewise.

gas/testsuite/

2009-08-18  H.J. Lu  <hongjiu.lu@intel.com>

	 PR gas/10531
	 * gas/elf/group2.d: New.
	 * gas/elf/group2.s: Likewise.
	 * gas/i386/debug1.d: Likewise.
	 * gas/i386/debug1.s: Likewise.

	* gas/elf/elf.exp: Run group2.

	* gas/i386/i386.exp: Run debug1 for both 32bit and 64bit.

Attachment: binutils-group-1.patch
Description: Text document