This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR gas/10531: Strange assembler warning message on section group
On Tue, Aug 18, 2009 at 09:23:25AM -0700, H.J. Lu wrote:
> On Mon, Aug 17, 2009 at 8:12 PM, Alan Modra<amodra@bigpond.net.au> wrote:
> > On Mon, Aug 17, 2009 at 04:07:21PM -0700, H.J. Lu wrote:
> >> We can't use bfd_get_section_by_name, subseg_new and subseg_get directly
> >> in dwarf2dbg.c since they don't know ELF section groups. ?This patch adds
> >> obj_get_section_by_name, obj_subseg_new and obj_subseg_get. ?Tested on
> >> Linux/ia32, Linux/ia64 and Linux/Intel64. ?OK to install?
> >
> > Have you tested this with a multi-obj assembler? ?I suspect that
> > something like x86-as --em=i386coff --gdwarf-2 will attempt to
> > access elf-only data structures. ?(That's a slightly ridiculous
> > set of command line options for x86, but we shouldn't have gas
> > segfault.) ?I think the proper patch needs some new fields in
> > struct format_ops and defines in obj-multi.h.
> >
>
> strcmp can't be used to check if 2 ELF sections have the same name.
> I added bfd_section_name_eq. OK to install?
This is a weird definition of "the same name". They have the same
name; they're just not the same section. What predicate do you really
need here?
--
Daniel Jacobowitz
CodeSourcery