This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix sign-extended immediates for SH on 64-bit host
On Sat, Aug 29, 2009 at 10:14:21AM +0900, Kaz Kojima wrote:
> Matt Fleming <matt@console-pimps.org> wrote:
> > Yep, this one works OK. The reason I used the macros was in anticipation
> > of there being other related bugs in the assembler ;-) Though I admit, I
> > haven't looked for any others.
>
> Ah, I see. BTW, I've missed that the copyright years of
> config/tc-sh.c should be updated. Could you please send
> the revised one with those changes to the list?
>
> Regards,
> kaz
Sure! How does this patch look?
Index: gas/config/tc-sh.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-sh.c,v
retrieving revision 1.132
diff -u -r1.132 tc-sh.c
--- gas/config/tc-sh.c 24 Jul 2009 11:45:00 -0000 1.132
+++ gas/config/tc-sh.c 29 Aug 2009 09:43:27 -0000
@@ -1,6 +1,6 @@
/* tc-sh.c -- Assemble code for the Renesas / SuperH SH
Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002,
- 2003, 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
+ 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
This file is part of GAS, the GNU Assembler.
@@ -4183,6 +4183,9 @@
val = ((val >> shift)
| ((long) -1 & ~ ((long) -1 >> shift)));
}
+
+ /* Extend sign for 64-bit host. */
+ val = ((val & 0xffffffff) ^ 0x80000000) - 0x80000000;
if (max != 0 && (val < min || val > max))
as_bad_where (fixP->fx_file, fixP->fx_line, _("offset out of range"));
else if (max != 0)